]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
io_uring/zcrx: don't leak pages on account failure
authorPavel Begunkov <asml.silence@gmail.com>
Mon, 21 Jul 2025 09:56:21 +0000 (10:56 +0100)
committerJens Axboe <axboe@kernel.dk>
Mon, 21 Jul 2025 12:47:45 +0000 (06:47 -0600)
Someone needs to release pinned pages in io_import_umem() if accounting
fails. Assign them to the area but return an error, the following
io_zcrx_free_area() will clean them up.

Fixes: 262ab205180d2 ("io_uring/zcrx: account area memory")
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/e19f283a912f200c0d427e376cb789fc3f3d69bc.1753091564.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
io_uring/zcrx.c

index 6b4bdefb40c465b07f96c8df537f09d97c5be1eb..6a983f1ab592ee33bd196ae8ea4b13cd536cc0ef 100644 (file)
@@ -199,15 +199,13 @@ static int io_import_umem(struct io_zcrx_ifq *ifq,
 
        mem->account_pages = io_count_account_pages(pages, nr_pages);
        ret = io_account_mem(ifq->ctx, mem->account_pages);
-       if (ret < 0) {
+       if (ret < 0)
                mem->account_pages = 0;
-               return ret;
-       }
 
        mem->pages = pages;
        mem->nr_folios = nr_pages;
        mem->size = area_reg->len;
-       return 0;
+       return ret;
 }
 
 static void io_release_area_mem(struct io_zcrx_mem *mem)