]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
dmaengine: idma64: Add check for dma_set_max_seg_size
authorChen Ni <nichen@iscas.ac.cn>
Wed, 3 Apr 2024 02:49:32 +0000 (02:49 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 16 Jun 2024 11:39:34 +0000 (13:39 +0200)
[ Upstream commit 2b1c1cf08a0addb6df42f16b37133dc7a351de29 ]

As the possible failure of the dma_set_max_seg_size(), it should be
better to check the return value of the dma_set_max_seg_size().

Fixes: e3fdb1894cfa ("dmaengine: idma64: set maximum allowed segment size for DMA")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20240403024932.3342606-1-nichen@iscas.ac.cn
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/dma/idma64.c

index af8777a1ec2e36b83a12f59402118e6359b4c2b1..89e4a3e1d5198f3193fbe402a67f3bbe8e1cb2ad 100644 (file)
@@ -594,7 +594,9 @@ static int idma64_probe(struct idma64_chip *chip)
 
        idma64->dma.dev = chip->sysdev;
 
-       dma_set_max_seg_size(idma64->dma.dev, IDMA64C_CTLH_BLOCK_TS_MASK);
+       ret = dma_set_max_seg_size(idma64->dma.dev, IDMA64C_CTLH_BLOCK_TS_MASK);
+       if (ret)
+               return ret;
 
        ret = dma_async_device_register(&idma64->dma);
        if (ret)