* nis/nis_callback.c (__nis_create_callback): Always call xdr_free

	for cleanup when cb!=NULL [Coverity CID 233].

diff --git a/ChangeLog b/ChangeLog
index f0555f09e7733986396de23a7b7adf8da0adfa28..ff66ed6e752f3d215e367512783d4285640f5401 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2006-05-25  Ulrich Drepper  <drepper@redhat.com>
+
+       * nis/nis_callback.c (__nis_create_callback): Always call xdr_free
+       for cleanup when cb!=NULL [Coverity CID 233].
+
 2006-05-24  Ulrich Drepper  <drepper@redhat.com>
 
        [BZ #2693]

diff --git a/nis/nis_callback.c b/nis/nis_callback.c
index 7c76f99b6b075509fa8e72a1c1bba47c81273a70..e0acd9683a0fb217474b6c0dc21f0a08f2cbb889 100644 (file)
--- a/nis/nis_callback.c
+++ b/nis/nis_callback.c
@@ -360,8 +360,7 @@ __nis_create_callback (int (*callback) (const_nis_name, const nis_object *,
     {
       if (cb->xprt)
        svc_destroy (cb->xprt);
-      if (cb->serv)
-       xdr_free ((xdrproc_t) _xdr_nis_server, (char *) cb->serv);
+      xdr_free ((xdrproc_t) _xdr_nis_server, (char *) cb->serv);
       free (cb);
     }
   if (!nomsg)