]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: stmmac: qcom-ethqos: move RGMII_CONFIG_DDR_MODE
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>
Fri, 27 Mar 2026 08:43:48 +0000 (08:43 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 31 Mar 2026 00:36:44 +0000 (17:36 -0700)
RGMII_CONFIG_DDR_MODE is always set irrespective of the speed. Move
this out of the switch.

Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Tested-by: Mohd Ayaan Anwar <mohd.anwar@oss.qualcomm.com>
Link: https://patch.msgid.link/E1w62nE-0000000E3CF-331r@rmk-PC.armlinux.org.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c

index d19331067459ec04fdd543e74031e993712643c2..34d9a6b2d023f263393b923eb9ab67ddecb2082a 100644 (file)
@@ -402,10 +402,10 @@ static int ethqos_rgmii_macro_init(struct qcom_ethqos *ethqos, int speed)
                return -EINVAL;
        }
 
+       rgmii_setmask(ethqos, RGMII_CONFIG_DDR_MODE, RGMII_IO_MACRO_CONFIG);
+
        switch (speed) {
        case SPEED_1000:
-               rgmii_setmask(ethqos, RGMII_CONFIG_DDR_MODE,
-                             RGMII_IO_MACRO_CONFIG);
                rgmii_clrmask(ethqos, RGMII_CONFIG_BYPASS_TX_ID_EN,
                              RGMII_IO_MACRO_CONFIG);
                rgmii_setmask(ethqos, RGMII_CONFIG_POS_NEG_DATA_SEL,
@@ -443,8 +443,6 @@ static int ethqos_rgmii_macro_init(struct qcom_ethqos *ethqos, int speed)
                break;
 
        case SPEED_100:
-               rgmii_setmask(ethqos, RGMII_CONFIG_DDR_MODE,
-                             RGMII_IO_MACRO_CONFIG);
                rgmii_setmask(ethqos, RGMII_CONFIG_BYPASS_TX_ID_EN,
                              RGMII_IO_MACRO_CONFIG);
                rgmii_clrmask(ethqos, RGMII_CONFIG_POS_NEG_DATA_SEL,
@@ -481,8 +479,6 @@ static int ethqos_rgmii_macro_init(struct qcom_ethqos *ethqos, int speed)
                break;
 
        case SPEED_10:
-               rgmii_setmask(ethqos, RGMII_CONFIG_DDR_MODE,
-                             RGMII_IO_MACRO_CONFIG);
                rgmii_setmask(ethqos, RGMII_CONFIG_BYPASS_TX_ID_EN,
                              RGMII_IO_MACRO_CONFIG);
                rgmii_clrmask(ethqos, RGMII_CONFIG_POS_NEG_DATA_SEL,