]> git.ipfire.org Git - thirdparty/apache/httpd.git/commitdiff
Attempt to review the proxy patch...
authorJoe Orton <jorton@apache.org>
Mon, 18 Jul 2005 14:39:01 +0000 (14:39 +0000)
committerJoe Orton <jorton@apache.org>
Mon, 18 Jul 2005 14:39:01 +0000 (14:39 +0000)
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/branches/2.0.x@219501 13f79535-47bb-0310-9956-ffa450edef68

STATUS

diff --git a/STATUS b/STATUS
index e60d614f86c6d2a02c5064388a30d3353ee22c0c..32448e1710edcfd77584e9e594f04eb6d28cae01 100644 (file)
--- a/STATUS
+++ b/STATUS
@@ -115,7 +115,17 @@ RELEASE SHOWSTOPPERS:
       Revert r219061 to properly test this patch, as r219061 masks the
       underlying bug (although it is a -good- patch in and of itself).
 
-       +1 wrowe, jim
+       +1: wrowe, jim
+       -1: jorton: this is a massive patch and extremely hard to review
+           for actual interesting content; it is mixed in with all sorts
+           of unrelated stuff.  It needs to at least be split up or
+           the unrelated stuff removed.
+
+           unrelated change: s/apr_strnatcasecmp/strcasecmp/
+           unrelated change: s/b/bb/ on variable+parameter names a few times
+           unrelated change: whitespaces changes all over the shop
+           spurious change:? send_request_body() appears to have been inlined
+           unrelated change: Via header handling
 
          trawick noted on list: we elected C-L not for efficiency, but because
                  it's the most widely supported [paraphrasing]