analysis: exit if table entries are stale

This commit causes Suricata to exit when a buffer from the analyzer
table is not recognized.

Since the table must match what's registered, exiting will bring noticed
to the condition.

diff --git a/src/detect-engine-analyzer.c b/src/detect-engine-analyzer.c
index 1f7acc92b798b0c9d0c9184ab7b208e600f62d66..1e1b510a7cb0794aec003085c6389e843fd4c4e0 100644 (file)
--- a/src/detect-engine-analyzer.c
+++ b/src/detect-engine-analyzer.c
@@ -963,6 +963,12 @@ static void EngineAnalysisItemsInit(void)
         DetectEngineAnalyzerItems *analyzer_item = &analyzer_items[i];
 
         analyzer_item->item_id = DetectBufferTypeGetByName(analyzer_item->item_name);
+        if (analyzer_item->item_id == -1) {
+            /* Mismatch between the analyzer_items array and what's supported */
+            FatalError(SC_ERR_INITIALIZATION,
+                       "unable to initialize engine-analysis table: detect buffer \"%s\" not recognized.",
+                       analyzer_item->item_name);
+        }
         analyzer_item->item_seen = false;
 
         if (analyzer_item->export_item_seen) {