]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
ftp: code clarifications
authorVictor Julien <vjulien@oisf.net>
Wed, 27 Apr 2022 18:19:09 +0000 (20:19 +0200)
committerVictor Julien <vjulien@oisf.net>
Mon, 9 May 2022 14:06:41 +0000 (16:06 +0200)
src/app-layer-ftp.c:945:49: style: Parameter 'ftp_state' can be declared with const [constParameter]
static FTPTransaction *FTPGetOldestTx(FtpState *ftp_state, FTPTransaction *starttx)
                                                ^

src/app-layer-ftp.c

index 3f96da9722c8f3e1f52499f0cde854e23e9b1e48..7bae47df74e733738b578a0365e1821c04017b77 100644 (file)
@@ -132,7 +132,7 @@ uint32_t ftp_max_line_len = 4096;
 SC_ATOMIC_DECLARE(uint64_t, ftp_memuse);
 SC_ATOMIC_DECLARE(uint64_t, ftp_memcap);
 
-static FTPTransaction *FTPGetOldestTx(FtpState *, FTPTransaction *);
+static FTPTransaction *FTPGetOldestTx(const FtpState *, FTPTransaction *);
 
 static void FTPParseMemcap(void)
 {
@@ -952,7 +952,7 @@ static void FTPStateFree(void *s)
  *
  * \retval transaction pointer when a transaction was found; NULL otherwise.
  */
-static FTPTransaction *FTPGetOldestTx(FtpState *ftp_state, FTPTransaction *starttx)
+static FTPTransaction *FTPGetOldestTx(const FtpState *ftp_state, FTPTransaction *starttx)
 {
     if (unlikely(!ftp_state)) {
         SCLogDebug("NULL state object; no transactions available");