]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: dac: ti-dac082s085: Fix alignment for DMA safety
authorJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 8 May 2022 17:56:41 +0000 (18:56 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 Aug 2022 12:41:32 +0000 (14:41 +0200)
[ Upstream commit 03a0cc77f164e4e59b970d50c6e9a6caf06dae80 ]

____cacheline_aligned is an insufficient guarantee for non-coherent DMA
on platforms with 128 byte cachelines above L1.  Switch to the updated
IIO_DMA_MINALIGN definition.

Fixes: 61011264c1af ("iio: dac: Add Texas Instruments 8/10/12-bit 2/4-channel DAC driver")
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Acked-by: Nuno Sá <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20220508175712.647246-62-jic23@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/iio/dac/ti-dac082s085.c

index 4e1156e6deb2d7c0e11b225a886f928c64d07480..f52ad8fa774740cb305a5e4a40b0a5d6ae3ff39b 100644 (file)
@@ -55,7 +55,7 @@ struct ti_dac_chip {
        bool powerdown;
        u8 powerdown_mode;
        u8 resolution;
-       u8 buf[2] ____cacheline_aligned;
+       u8 buf[2] __aligned(IIO_DMA_MINALIGN);
 };
 
 #define WRITE_NOT_UPDATE(chan) (0x00 | (chan) << 6)