]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu_driver.c: modernize qemuDomainMigrateBegin3Params()
authorDaniel Henrique Barboza <danielhb413@gmail.com>
Mon, 13 Jul 2020 09:49:36 +0000 (06:49 -0300)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 13 Jul 2020 15:17:35 +0000 (17:17 +0200)
Use g_autofree and remove the unneeded 'cleanup' label.

Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
src/qemu/qemu_driver.c

index 8ea4197d000129b91cfff2b346d2b833bc931a13..6b47e28e99b3cddf307ea4c451fca34f6aab90d3 100644 (file)
@@ -12346,14 +12346,13 @@ qemuDomainMigrateBegin3Params(virDomainPtr domain,
 {
     const char *xmlin = NULL;
     const char *dname = NULL;
-    const char **migrate_disks = NULL;
+    g_autofree const char **migrate_disks = NULL;
     int nmigrate_disks;
-    char *ret = NULL;
     virDomainObjPtr vm;
 
     virCheckFlags(QEMU_MIGRATION_FLAGS, NULL);
     if (virTypedParamsValidate(params, nparams, QEMU_MIGRATION_PARAMETERS) < 0)
-        goto cleanup;
+        return NULL;
 
     if (virTypedParamsGetString(params, nparams,
                                 VIR_MIGRATE_PARAM_DEST_XML,
@@ -12361,30 +12360,26 @@ qemuDomainMigrateBegin3Params(virDomainPtr domain,
         virTypedParamsGetString(params, nparams,
                                 VIR_MIGRATE_PARAM_DEST_NAME,
                                 &dname) < 0)
-        goto cleanup;
+        return NULL;
 
     nmigrate_disks = virTypedParamsGetStringList(params, nparams,
                                                  VIR_MIGRATE_PARAM_MIGRATE_DISKS,
                                                  &migrate_disks);
 
     if (nmigrate_disks < 0)
-        goto cleanup;
+        return NULL;
 
     if (!(vm = qemuDomainObjFromDomain(domain)))
-        goto cleanup;
+        return NULL;
 
     if (virDomainMigrateBegin3ParamsEnsureACL(domain->conn, vm->def) < 0) {
         virDomainObjEndAPI(&vm);
-        goto cleanup;
+        return NULL;
     }
 
-    ret = qemuMigrationSrcBegin(domain->conn, vm, xmlin, dname,
-                                cookieout, cookieoutlen,
-                                nmigrate_disks, migrate_disks, flags);
-
- cleanup:
-    VIR_FREE(migrate_disks);
-    return ret;
+    return qemuMigrationSrcBegin(domain->conn, vm, xmlin, dname,
+                                 cookieout, cookieoutlen,
+                                 nmigrate_disks, migrate_disks, flags);
 }