]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
rpc: handle missing switch enum cases
authorDaniel P. Berrangé <berrange@redhat.com>
Wed, 14 Feb 2018 09:43:59 +0000 (09:43 +0000)
committerDaniel P. Berrangé <berrange@redhat.com>
Wed, 21 Feb 2018 16:59:28 +0000 (16:59 +0000)
Ensure all enum cases are listed in switch statements.

Reviewed-by: John Ferlan <jferlan@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
src/rpc/virnetclient.c
src/rpc/virnetclientprogram.c
src/rpc/virnetserverprogram.c

index 8aeacf87748a3c85fcaab87a7fa3bfae4b02e95d..0c8d58c32c1281708a295d80bbdc8cad2c145997 100644 (file)
@@ -1287,6 +1287,8 @@ virNetClientCallDispatch(virNetClientPtr client)
     case VIR_NET_STREAM_HOLE: /* Sparse stream protocol*/
         return virNetClientCallDispatchStream(client);
 
+    case VIR_NET_CALL:
+    case VIR_NET_CALL_WITH_FDS:
     default:
         virReportError(VIR_ERR_RPC,
                        _("got unexpected RPC call prog %d vers %d proc %d type %d"),
index d81a0554245bfbd729d60ccb69214692de404137..505b40fc4b11b024e444a81b75467e4b9fc8e515 100644 (file)
@@ -384,6 +384,7 @@ int virNetClientProgramCall(virNetClientProgramPtr prog,
         virNetClientProgramDispatchError(prog, msg);
         goto error;
 
+    case VIR_NET_CONTINUE:
     default:
         virReportError(VIR_ERR_RPC,
                        _("Unexpected message status %d"), msg->header.status);
index 557651ffbd91b447c8263a1dd0691a240cf96308..75b0052cdb000605b933b53dbf3b18b072173f61 100644 (file)
@@ -324,6 +324,10 @@ int virNetServerProgramDispatch(virNetServerProgramPtr prog,
         ret = 0;
         break;
 
+    case VIR_NET_REPLY:
+    case VIR_NET_REPLY_WITH_FDS:
+    case VIR_NET_MESSAGE:
+    case VIR_NET_STREAM_HOLE:
     default:
         virReportError(VIR_ERR_RPC,
                        _("Unexpected message type %u"),