Workaround for clang static analyzer bug.

diff --git a/lib/dns/badcache.c b/lib/dns/badcache.c
index 42cef0df8eae67f903863516c2f8187a2a542950..b566c21ad2efcf2d42dbd0112d033eab7e19080d 100644 (file)
--- a/lib/dns/badcache.c
+++ b/lib/dns/badcache.c
@@ -150,6 +150,14 @@ badcache_resize(dns_badcache_t *bc, isc_time_t *now) {
                newsize = bc->size * 2 + 1;
        } else {
                newsize = (bc->size - 1) / 2;
+#ifdef __clang_analyzer__
+               /*
+                * XXXWPK there's a bug in clang static analyzer -
+                * `value % newsize` is considered undefined even though
+                * we check if newsize is larger than 0. This helps.
+                */
+               newsize += 1;
+#endif
        }
        RUNTIME_CHECK(newsize > 0);