dns update: zero flags and reserved

This is the observed behaviour on Windows.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/selftest/knownfail.d/dns-aging b/selftest/knownfail.d/dns-aging
index bff873cc1ca0f583d7e3a71d090841d9d626ae67..dd6998d75d82ab500ab81c2cb207ddb03263dc8b 100644 (file)
--- a/selftest/knownfail.d/dns-aging
+++ b/selftest/knownfail.d/dns-aging
@@ -30,7 +30,6 @@ samba.tests.dns_aging.+test_dns_add_sibling_12_7_days_no_aging_touch
 samba.tests.dns_aging.+test_dns_add_sibling_2_7_days_aging
 samba.tests.dns_aging.+test_dns_add_sibling_2_7_days_aging_touch
 samba.tests.dns_aging.+test_dns_add_sibling_2_7_days_no_aging_touch
-samba.tests.dns_aging.+test_add_update_dwFlags
 samba.tests.dns_aging.+test_add_update_dwSerial
 samba.tests.dns_aging.+test_add_update_dwSerial_2
 samba.tests.dns_aging.+test_add_update_many

diff --git a/source4/dns_server/dns_update.c b/source4/dns_server/dns_update.c
index feacfaefe6553c9c79d31c625e311dc3ab7044a3..2d5f353671e918166ac2670f1e247b7b5cd5b614 100644 (file)
--- a/source4/dns_server/dns_update.c
+++ b/source4/dns_server/dns_update.c
@@ -572,7 +572,8 @@ static WERROR handle_one_update(struct dns_server *dns,
                        recs[i].wType = recs[rcount].wType;
                        recs[i].dwTtlSeconds = recs[rcount].dwTtlSeconds;
                        recs[i].rank = recs[rcount].rank;
-
+                       recs[i].dwReserved = 0;
+                       recs[i].flags = 0;
                        werror = dns_replace_records(dns, mem_ctx, dn,
                                                     needs_add, recs, rcount);
                        W_ERROR_NOT_OK_RETURN(werror);