]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ALSA: pcsp: Use safer strscpy() instead of strcpy()
authorTakashi Iwai <tiwai@suse.de>
Thu, 10 Jul 2025 10:05:49 +0000 (12:05 +0200)
committerTakashi Iwai <tiwai@suse.de>
Fri, 11 Jul 2025 07:51:09 +0000 (09:51 +0200)
Use a safer function strscpy() instead of strcpy() for copying to
arrays.

Only idiomatic code replacement, and no functional changes.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20250710100727.22653-8-tiwai@suse.de
sound/drivers/pcsp/pcsp.c
sound/drivers/pcsp/pcsp_lib.c
sound/drivers/pcsp/pcsp_mixer.c

index e8482c2290c3dfbf1d3ed560380b152f67abf21c..ff6bb375c9001445f98793feb512953f5ac9f8e2 100644 (file)
@@ -122,8 +122,8 @@ static int snd_card_pcsp_probe(int devnum, struct device *dev)
        if (err < 0)
                return err;
 
-       strcpy(card->driver, "PC-Speaker");
-       strcpy(card->shortname, "pcsp");
+       strscpy(card->driver, "PC-Speaker");
+       strscpy(card->shortname, "pcsp");
        sprintf(card->longname, "Internal PC-Speaker at port 0x%x",
                pcsp_chip.port);
 
index d9bc1ea1b53ccc56304873c1f27e30a7b064add1..80b313f4fcd36ad7c04abe335fc4e2abaf8ac452 100644 (file)
@@ -340,7 +340,7 @@ int snd_pcsp_new_pcm(struct snd_pcsp *chip)
 
        chip->pcm->private_data = chip;
        chip->pcm->info_flags = SNDRV_PCM_INFO_HALF_DUPLEX;
-       strcpy(chip->pcm->name, "pcsp");
+       strscpy(chip->pcm->name, "pcsp");
 
        snd_pcm_set_managed_buffer_all(chip->pcm,
                                       SNDRV_DMA_TYPE_CONTINUOUS,
index c0ae942358b9b367621fd75ddb9eb9ec90af969c..27d6150329a860b4ea16fc4ee52ca19bd51b9e9b 100644 (file)
@@ -158,7 +158,7 @@ int snd_pcsp_new_mixer(struct snd_pcsp *chip, int nopcm)
        if (err < 0)
                return err;
 
-       strcpy(card->mixername, "PC-Speaker");
+       strscpy(card->mixername, "PC-Speaker");
 
        return 0;
 }