logging: add test for log groups

Besides testing the API, running this test also ensures all log groups
have been properly defined (as long as kr_assertions are turned on).

diff --git a/daemon/lua/log.test.lua b/daemon/lua/log.test.lua
new file mode 100644 (file)
index 0000000..0b73c56
--- /dev/null
+++ b/daemon/lua/log.test.lua
@@ -0,0 +1,15 @@
+local function test_log_group()
+       same(get_log_group()['system'], nil, '"system" log group not logged by default')
+       add_log_group('system')
+       same(get_log_group()['system'], true, 'adding "system" log group')
+       add_log_group('devel')
+       same(get_log_group()['devel'], true, 'adding another ("devel") log group')
+       del_log_group('system')
+       same(get_log_group()['system'], nil, 'removing "system" log group')
+       boom(add_log_group, { 'nonexistent' }, "nonexistent group cant't be added")
+       boom(del_log_group, { 'nonexistent2' }, "nonexistent2 group can't be removed")
+end
+
+return {
+       test_log_group,
+}

diff --git a/daemon/lua/meson.build b/daemon/lua/meson.build
index ee761d56ec8ec4655e69a0e52d80a825d74caee4..ee71927b56d9d3da718e63edd65657ee1e937f16 100644 (file)
--- a/daemon/lua/meson.build
+++ b/daemon/lua/meson.build
@@ -4,6 +4,7 @@
 config_tests += [
   ['controlsock', files('controlsock.test.lua')],
   ['krprint', files('krprint.test.lua')],
+  ['log', files('log.test.lua')],
   ['ta', files('trust_anchors.test/ta.test.lua')],
   ['ta_bootstrap', files('trust_anchors.test/bootstrap.test.lua'), ['y2k38']],
 ]

diff --git a/lib/log.c b/lib/log.c
index 81792645fbcb02a9799835905a6508679cdf9288..5cb996b0c76313c71d0367984a5116824eb03a0f 100644 (file)
--- a/lib/log.c
+++ b/lib/log.c
@@ -39,7 +39,7 @@ log_group_names_t log_group_names[] = {
        GRP_NAME_ITEM(LOG_GRP_DOH),
        GRP_NAME_ITEM(LOG_GRP_DNSSEC),
        GRP_NAME_ITEM(LOG_GRP_HINT),
-       GRP_NAME_ITEM(LOG_GRP_PLAN),  // TODO check all log levels are defined - how?
+       GRP_NAME_ITEM(LOG_GRP_PLAN),
        GRP_NAME_ITEM(LOG_GRP_ITERATOR),
        GRP_NAME_ITEM(LOG_GRP_VALIDATOR),
        GRP_NAME_ITEM(LOG_GRP_RESOLVER),