version: hide git revision if unknown

This happens when suricata-update is installed bundled with
Suricata.  This is more a relic from the earlier days
of Suricata-Update when more users were likely to install
it directly from git anyways.

diff --git a/suricata/update/main.py b/suricata/update/main.py
index b1ad7f091d06a27c6d27f6eb728cb39bb429b9f5..3fa2b0ddb2f7f2cd424e06e3331ff28e1f8995a7 100644 (file)
--- a/suricata/update/main.py
+++ b/suricata/update/main.py
@@ -67,7 +67,7 @@ from suricata.update.version import version
 try:
     from suricata.update.revision import revision
 except:
-    revision = "unknown"
+    revision = None
 
 # Initialize logging, use colour if on a tty.
 if len(logging.root.handlers) == 0 and os.isatty(sys.stderr.fileno()):
@@ -1052,7 +1052,8 @@ def _main():
     global_args, rem = global_parser.parse_known_args()
 
     if global_args.version:
-        print("suricata-update version %s (rev: %s)" % (version, revision))
+        revision_string = " (rev: %s)" % (revision) if revision else ""
+        print("suricata-update version {}{}".format(version, revision_string))
         return 0
 
     if not rem or rem[0].startswith("-"):