chan_sip: Always use fromdomain if set for domain, even if callerid is set to restricted.

(closes issue ASTERISK-20841)
Reported by: Kelly Goedert
........

Merged revisions 411021 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........

Merged revisions 411022 from http://svn.asterisk.org/svn/asterisk/branches/11
........

Merged revisions 411023 from http://svn.asterisk.org/svn/asterisk/branches/12

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@411024 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/channels/chan_sip.c b/channels/chan_sip.c
index 2198ee625c8a9e9de9c0f726ba01a2e2d2ef5522..23c502c8240c514cf970e335198f373aa046134f 100644 (file)
--- a/channels/chan_sip.c
+++ b/channels/chan_sip.c
@@ -13957,7 +13957,9 @@ static void initreqprep(struct sip_request *req, struct sip_pvt *p, int sipmetho
 
        snprintf(p->lastmsg, sizeof(p->lastmsg), "Init: %s", sip_methods[sipmethod].text);
 
-       d = S_OR(p->fromdomain, ast_sockaddr_stringify_host_remote(&p->ourip));
+       if (ast_strlen_zero(p->fromdomain)) {
+               d = ast_sockaddr_stringify_host_remote(&p->ourip);
+       }
        if (p->owner) {
                connected_id = ast_channel_connected_effective_id(p->owner);
 
@@ -14008,6 +14010,12 @@ static void initreqprep(struct sip_request *req, struct sip_pvt *p, int sipmetho
        else /* Save for any further attempts */
                ast_string_field_set(p, fromname, n);
 
+       /* Allow domain to be overridden */
+       if (!ast_strlen_zero(p->fromdomain))
+               d = p->fromdomain;
+       else /* Save for any further attempts */
+               ast_string_field_set(p, fromdomain, d);
+
        ast_copy_string(tmp_l, l, sizeof(tmp_l));
        if (sip_cfg.pedanticsipchecking) {
                ast_escape_quoted(n, tmp_n, sizeof(tmp_n));