]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
mtd: rawnand: cadence: Fix return type of CDMA send-and-wait helper
authorAlok Tiwari <alok.a.tiwari@oracle.com>
Fri, 19 Dec 2025 11:09:30 +0000 (03:09 -0800)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Mon, 19 Jan 2026 10:13:17 +0000 (11:13 +0100)
cadence_nand_cdma_send_and_wait() propagates negative errno values
from cadence_nand_cdma_send(), returns -ETIMEDOUT on failure and -EIO
when the CDMA engine reports a command failure.

However, it is declared as u32, causing error codes to wrap.
Change the return type to int to correctly propagate errors.

Fixes: ec4ba01e894d ("mtd: rawnand: Add new Cadence NAND driver to MTD subsystem")
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
drivers/mtd/nand/raw/cadence-nand-controller.c

index 5f037753f78c82295880f71c49c31b7619cae7a3..99135ec230105ea62ae96e3378b7d883e3cf6c83 100644 (file)
@@ -1066,7 +1066,7 @@ static int cadence_nand_cdma_send(struct cdns_nand_ctrl *cdns_ctrl,
 }
 
 /* Send SDMA command and wait for finish. */
-static u32
+static int
 cadence_nand_cdma_send_and_wait(struct cdns_nand_ctrl *cdns_ctrl,
                                u8 thread)
 {