]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
hw/scsi: Use error_setg_file_open() for a better error message
authorMarkus Armbruster <armbru@redhat.com>
Fri, 21 Nov 2025 12:14:29 +0000 (13:14 +0100)
committerPhilippe Mathieu-Daudé <philmd@linaro.org>
Tue, 25 Nov 2025 21:41:49 +0000 (22:41 +0100)
The error message changes from

    vhost-scsi: open vhost char device failed: REASON

to

    Could not open '/dev/vhost-scsi': REASON

I think the exact file name is more useful to know than the file's
purpose.

We could put back the "vhost-scsi: " prefix with error_prepend().  Not
worth the bother.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dave@treblig.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20251121121438.1249498-7-armbru@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
hw/scsi/vhost-scsi.c

index cdf405b0f8686b429b4702dd36d06f229c7ad139..239138c931651ce537a7565fbbf2d45d43614d2b 100644 (file)
@@ -245,8 +245,7 @@ static void vhost_scsi_realize(DeviceState *dev, Error **errp)
     } else {
         vhostfd = open("/dev/vhost-scsi", O_RDWR);
         if (vhostfd < 0) {
-            error_setg(errp, "vhost-scsi: open vhost char device failed: %s",
-                       strerror(errno));
+            error_setg_file_open(errp, errno, "/dev/vhost-scsi");
             return;
         }
     }