]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3:smbd: Don’t free the caller’s buffer (CID 1610056)
authorJennifer Sutton <jennifersutton@catalyst.net.nz>
Fri, 2 Aug 2024 02:42:10 +0000 (14:42 +1200)
committerJo Sutton <jsutton@samba.org>
Mon, 26 May 2025 02:41:37 +0000 (02:41 +0000)
Signed-off-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
source3/smbd/smb1_process.c

index a1970b9e252a46281cb361d1235bab4edb2f5d5c..0dfefa147dfc2f4be092aa726c34f07cf4af7c6d 100644 (file)
@@ -255,7 +255,9 @@ bool smb1_srv_send(struct smbXsrv_connection *xconn,
        len = smb_len_large(buf_out) + 4;
 
        ret = write_data(xconn->transport.sock, buf_out, len);
-       srv_free_enc_buffer(xconn, encrypted_buf);
+       if (encrypted_buf != buffer) {
+               srv_free_enc_buffer(xconn, encrypted_buf);
+       }
        if (ret <= 0) {
                int saved_errno = errno;
                /*