]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4:kdc: avoid a leak on error
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Wed, 12 Nov 2025 02:59:18 +0000 (15:59 +1300)
committerJennifer Sutton <jsutton@samba.org>
Thu, 20 Nov 2025 21:25:39 +0000 (21:25 +0000)
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>
source4/kdc/db-glue.c

index 50ad2cf12f918ccbcd911bfd6281a6f77fbdd9ad..0ce276aee18247c0354da1cd8ac330961a6973a0 100644 (file)
@@ -3464,11 +3464,11 @@ static krb5_error_code samba_kdc_lookup_client(krb5_context context,
 
                        with_dollar = talloc_asprintf(mem_ctx, "%s$",
                                                     fallback_account);
+                       TALLOC_FREE(fallback_account);
                        if (with_dollar == NULL) {
                                TALLOC_FREE(fallback_realm);
                                return ENOMEM;
                        }
-                       TALLOC_FREE(fallback_account);
 
                        ret = smb_krb5_make_principal(context,
                                                      &fallback_principal,