Clone the current VPN profile before updating the password

Storing the password on the original object would be problematic in case
the user mistypes the password (no prompt would be shown the second time).

An alternative would be to just return the ID of the selected profile
and then fetch it from the database.

diff --git a/src/frontends/android/src/org/strongswan/android/ui/MainActivity.java b/src/frontends/android/src/org/strongswan/android/ui/MainActivity.java
index 7387dab8d38cad5b51639b54d8613bab1031605c..50b2bfbe51235746519e0a811db082fcd19c7ba1 100644 (file)
--- a/src/frontends/android/src/org/strongswan/android/ui/MainActivity.java
+++ b/src/frontends/android/src/org/strongswan/android/ui/MainActivity.java
@@ -179,6 +179,8 @@ public class MainActivity extends Activity implements OnVpnProfileSelectedListen
                                @Override
                                public void onClick(DialogInterface dialog, int whichButton)
                                {
+                                       /* let's work on a clone of the profile when updating the password */
+                                       activeProfile = activeProfile.clone();
                                        activeProfile.setPassword(password.getText().toString().trim());
                                        prepareVpnService();
                                }