]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4:scripting: fix gen_hresult.py
authorStefan Metzmacher <metze@samba.org>
Mon, 16 Dec 2024 13:43:41 +0000 (14:43 +0100)
committerGünther Deschner <gd@samba.org>
Wed, 18 Dec 2024 17:29:37 +0000 (17:29 +0000)
Commit 6877e4849e81ed8f7f355fa4069f13a134e999ce reversed the
return values of hresult_errstr() and hresult_errstr_const().

hresult_errstr() should return "HRES_SEC_E_WRONG_PRINCIPAL",
while hresult_errstr_const() should return
"The target principal name is incorrect.".

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15769

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
source4/scripting/bin/gen_hresult.py

index 3caca259436fb812eee5a8bcb8ae943e9a7419ea..dec0adf11be12f02f5e9a3cae23edab000c48321 100755 (executable)
@@ -101,7 +101,7 @@ def generateSourceFile(out_file, errors):
     out_file.write("   switch (HRES_ERROR_V(err_code)) {\n")
     for err in errors:
         out_file.write(f'            case 0x{err.err_code:X}:\n')
-        out_file.write(f'                result = \"{err.err_define}\";\n')
+        out_file.write(f'                result = \"{err.err_string}\";\n')
         out_file.write(f'                break;\n')
     out_file.write("   }\n")
     out_file.write("\n")
@@ -120,7 +120,7 @@ def generateSourceFile(out_file, errors):
     out_file.write("   switch (HRES_ERROR_V(err_code)) {\n")
     for err in errors:
         out_file.write(f'            case 0x{err.err_code:X}:\n')
-        out_file.write(f'                return \"{err.err_string}\";\n')
+        out_file.write(f'                return \"{err.err_define}\";\n')
         out_file.write(f'                break;\n')
     out_file.write("   }\n")
     out_file.write("   snprintf(msg, sizeof(msg), \"HRES code 0x%08x\", HRES_ERROR_V(err_code));\n")