apps/app_dial: Set the DIALSTATUS to NOANSWER on privacy option 5

If the callee selects option '5' using the Dial application's privacy
(P) option, the DIALSTATUS is erroneously set to ANSWER. This option
reflects the callee sending the caller to VoiceMail one time; the call
is definitely *not* ANSWERed in such a scenario. With this patch, the
DIALSTATUS is instead set to NOANSWER, which is the same DIALSTATUS that
is set when the 'send to VoiceMail every time' option is set.

ASTERISK-25691

Change-Id: Iaf0c9f0fa00545e7366443875e2bb7d9a89a1358

diff --git a/apps/app_dial.c b/apps/app_dial.c
index 48193b5a0d6c59fb781ab73768ea69dc8050dddb..c427faf6e1696c20fed2cd21bc26595d7c46fdb4 100644 (file)
--- a/apps/app_dial.c
+++ b/apps/app_dial.c
@@ -1919,9 +1919,10 @@ static int do_privacy(struct ast_channel *chan, struct ast_channel *peer,
                ast_copy_string(pa->status, "DONTCALL", sizeof(pa->status));
                break;
        case '5':
-               /* XXX should we set status to DENY ? */
-               if (ast_test_flag64(opts, OPT_PRIVACY))
+               if (ast_test_flag64(opts, OPT_PRIVACY)) {
+                       ast_copy_string(pa->status, "NOANSWER", sizeof(pa->status));
                        break;
+               }
                /* if not privacy, then 5 is the same as "default" case */
        default: /* bad input or -1 if failure to start autoservice */
                /* well, if the user messes up, ... he had his chance... What Is The Best Thing To Do?  */