tools/cgxset: use exit code 129 on invalid usage

The exit code 1 refers to general error and using -1 wraps to
255, both codes do not signify bad arguments. Let's use exit code 129
(EXIT_BADARGS) for hinting to the users about invalid usage.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

diff --git a/src/tools/cgxset.c b/src/tools/cgxset.c
index 3e02fe703738c7924711b8c1ce1d53ba381cd679..de0d11413c1c31d6b7562bd51c40ea5777678e0a 100644 (file)
--- a/src/tools/cgxset.c
+++ b/src/tools/cgxset.c
@@ -102,7 +102,7 @@ STATIC int parse_r_flag(const char * const program_name, const char * const name
        buf = strtok(copy, "=");
        if (buf == NULL) {
                err("%s: wrong parameter of option -r: %s\n", program_name, optarg);
-               ret = -1;
+               ret = EXIT_BADARGS;
                goto err;
        }
 
@@ -118,7 +118,7 @@ STATIC int parse_r_flag(const char * const program_name, const char * const name
 
        if (strlen(buf) == 0) {
                err("%s: wrong parameter of option -r: %s\n", program_name, optarg);
-               ret = -1;
+               ret = EXIT_BADARGS;
                goto err;
        }
 
@@ -165,7 +165,7 @@ int main(int argc, char *argv[])
                case 'r':
                        if ((flags &  FL_COPY) != 0) {
                                usage(1, argv[0]);
-                               ret = -1;
+                               ret = EXIT_BADARGS;
                                goto err;
                        }
                        flags |= FL_RULES;
@@ -191,7 +191,7 @@ int main(int argc, char *argv[])
                case COPY_FROM_OPTION:
                        if (flags != 0) {
                                usage(1, argv[0]);
-                               ret = -1;
+                               ret = EXIT_BADARGS;
                                goto err;
                        }
                        flags |= FL_COPY;
@@ -209,7 +209,7 @@ int main(int argc, char *argv[])
                        break;
                default:
                        usage(1, argv[0]);
-                       ret = -1;
+                       ret = EXIT_BADARGS;
                        goto err;
                }
        }
@@ -217,13 +217,13 @@ int main(int argc, char *argv[])
        /* no cgroup name */
        if (!argv[optind]) {
                err("%s: no cgroup specified\n", argv[0]);
-               ret = -1;
+               ret = EXIT_BADARGS;
                goto err;
        }
 
        if (flags == 0) {
                err("%s: no name-value pair was set\n", argv[0]);
-               ret = -1;
+               ret = EXIT_BADARGS;
                goto err;
        }