]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
staging: rtl8723bs: Fix spacing coding style issues in HalHWImg8723B_BB.c
authorMahad Ibrahim <mahad.ibrahim.dev@gmail.com>
Mon, 12 Jan 2026 17:42:22 +0000 (22:42 +0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 16 Jan 2026 13:02:43 +0000 (14:02 +0100)
Fix checkpatch.pl checks regarding "spaces preferred around that"
operator.

Adhere to kernel coding standards by adding spaces around arithmetic and
bitwise operations.

Signed-off-by: Mahad Ibrahim <mahad.ibrahim.dev@gmail.com>
Link: https://patch.msgid.link/20260112174227.14922-6-mahad.ibrahim.dev@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/hal/HalHWImg8723B_BB.c

index 630dace0af47d7a11251a9275aaac7a257c42f36..5fcb9420fb3dce10e5dc9f697d45dc947ec67823 100644 (file)
@@ -217,7 +217,7 @@ void ODM_ReadAndConfig_MP_8723B_AGC_TAB(struct dm_odm_t *pDM_Odm)
 
        for (i = 0; i < ArrayLen; i += 2) {
                u32 v1 = Array[i];
-               u32 v2 = Array[i+1];
+               u32 v2 = Array[i + 1];
 
                /*  This (offset, data) pair doesn't care the condition. */
                if (v1 < 0x40000000) {
@@ -226,7 +226,7 @@ void ODM_ReadAndConfig_MP_8723B_AGC_TAB(struct dm_odm_t *pDM_Odm)
                } else {
                        /*  This line is the beginning of branch. */
                        bool bMatched = true;
-                       u8  cCond  = (u8)((v1 & (BIT29|BIT28)) >> 28);
+                       u8  cCond  = (u8)((v1 & (BIT29 | BIT28)) >> 28);
 
                        if (cCond == COND_ELSE) { /*  ELSE, ENDIF */
                                bMatched = true;
@@ -246,22 +246,22 @@ void ODM_ReadAndConfig_MP_8723B_AGC_TAB(struct dm_odm_t *pDM_Odm)
                                 *   Condition isn't matched.
                                 *   Discard the following (offset, data) pairs.
                                 */
-                               while (v1 < 0x40000000 && i < ArrayLen-2)
+                               while (v1 < 0x40000000 && i < ArrayLen - 2)
                                        READ_NEXT_PAIR(v1, v2, i);
 
                                i -= 2; /*  prevent from for-loop += 2 */
                        } else {
                                /*  Configure matched pairs and skip to end of if-else. */
-                               while (v1 < 0x40000000 && i < ArrayLen-2) {
+                               while (v1 < 0x40000000 && i < ArrayLen - 2) {
                                        odm_ConfigBB_AGC_8723B(pDM_Odm, v1, bMaskDWord, v2);
                                        READ_NEXT_PAIR(v1, v2, i);
                                }
 
                                /*  Keeps reading until ENDIF. */
-                               cCond = (u8)((v1 & (BIT29|BIT28)) >> 28);
-                               while (cCond != COND_ENDIF && i < ArrayLen-2) {
+                               cCond = (u8)((v1 & (BIT29 | BIT28)) >> 28);
+                               while (cCond != COND_ENDIF && i < ArrayLen - 2) {
                                        READ_NEXT_PAIR(v1, v2, i);
-                                       cCond = (u8)((v1 & (BIT29|BIT28)) >> 28);
+                                       cCond = (u8)((v1 & (BIT29 | BIT28)) >> 28);
                                }
                        }
                }
@@ -477,7 +477,7 @@ void ODM_ReadAndConfig_MP_8723B_PHY_REG(struct dm_odm_t *pDM_Odm)
 
        for (i = 0; i < ArrayLen; i += 2) {
                u32 v1 = Array[i];
-               u32 v2 = Array[i+1];
+               u32 v2 = Array[i + 1];
 
                /*  This (offset, data) pair doesn't care the condition. */
                if (v1 < 0x40000000) {
@@ -486,7 +486,7 @@ void ODM_ReadAndConfig_MP_8723B_PHY_REG(struct dm_odm_t *pDM_Odm)
                } else {
                        /*  This line is the beginning of branch. */
                        bool bMatched = true;
-                       u8  cCond  = (u8)((v1 & (BIT29|BIT28)) >> 28);
+                       u8  cCond  = (u8)((v1 & (BIT29 | BIT28)) >> 28);
 
                        if (cCond == COND_ELSE) { /*  ELSE, ENDIF */
                                bMatched = true;
@@ -506,21 +506,21 @@ void ODM_ReadAndConfig_MP_8723B_PHY_REG(struct dm_odm_t *pDM_Odm)
                                 *   Condition isn't matched.
                                 *   Discard the following (offset, data) pairs.
                                 */
-                               while (v1 < 0x40000000 && i < ArrayLen-2)
+                               while (v1 < 0x40000000 && i < ArrayLen - 2)
                                        READ_NEXT_PAIR(v1, v2, i);
 
                                i -= 2; /*  prevent from for-loop += 2 */
                        } else { /*  Configure matched pairs and skip to end of if-else. */
-                               while (v1 < 0x40000000 && i < ArrayLen-2) {
+                               while (v1 < 0x40000000 && i < ArrayLen - 2) {
                                        odm_ConfigBB_PHY_8723B(pDM_Odm, v1, bMaskDWord, v2);
                                        READ_NEXT_PAIR(v1, v2, i);
                                }
 
                                /*  Keeps reading until ENDIF. */
-                               cCond = (u8)((v1 & (BIT29|BIT28)) >> 28);
-                               while (cCond != COND_ENDIF && i < ArrayLen-2) {
+                               cCond = (u8)((v1 & (BIT29 | BIT28)) >> 28);
+                               while (cCond != COND_ENDIF && i < ArrayLen - 2) {
                                        READ_NEXT_PAIR(v1, v2, i);
-                                       cCond = (u8)((v1 & (BIT29|BIT28)) >> 28);
+                                       cCond = (u8)((v1 & (BIT29 | BIT28)) >> 28);
                                }
                        }
                }
@@ -550,9 +550,9 @@ void ODM_ReadAndConfig_MP_8723B_PHY_REG_PG(struct dm_odm_t *pDM_Odm)
 
        for (i = 0; i < ARRAY_SIZE(Array_MP_8723B_PHY_REG_PG); i += 4) {
                u32 v1 = Array[i];
-               u32 v2 = Array[i+1];
-               u32 v3 = Array[i+2];
-               u32 v4 = Array[i+3];
+               u32 v2 = Array[i + 1];
+               u32 v3 = Array[i + 2];
+               u32 v4 = Array[i + 3];
 
                odm_ConfigBB_PHY_REG_PG_8723B(pDM_Odm, v1, v2, v3, v4);
        }