]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4:kdc: Erase key data
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Thu, 10 Aug 2023 04:58:31 +0000 (16:58 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Mon, 14 Aug 2023 04:57:34 +0000 (04:57 +0000)
If we’re going to zero the keys before freeing them, we might as well do
it properly.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/kdc/sdb_to_kdb.c

index 466e53921cdab878d489264de573e14d981cce67..7214cbc317e1ba599eb5c938a107eef191987439 100644 (file)
@@ -222,7 +222,7 @@ static void free_krb5_db_entry(krb5_context context,
                        for (j = 0; j < k->key_data[i].key_data_ver; j++) {
                                if (k->key_data[i].key_data_length[j] != 0) {
                                        if (k->key_data[i].key_data_contents[j] != NULL) {
-                                               memset(k->key_data[i].key_data_contents[j], 0, k->key_data[i].key_data_length[j]);
+                                               BURN_PTR_SIZE(k->key_data[i].key_data_contents[j], k->key_data[i].key_data_length[j]);
                                                free(k->key_data[i].key_data_contents[j]);
                                        }
                                }