ASoC: codecs: nau8325: Silence uninitialized variables warnings

commit 2c7e5e17c05f1d5e10e63e1baff2b362cd08dcd6 upstream.

clang W=1 builds warn:

  nau8325.c:430:13: error: variable 'n2_max' is uninitialized when used here [-Werror,-Wuninitialized]

which are false positive, because the variables will be always
initialized when used (guarded by mclk_max!=0 check).  However
initializing them upfront makes the code more obvious and easier, plus
it silences the warning.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Link: https://patch.msgid.link/20251203140611.87191-2-krzysztof.kozlowski@oss.qualcomm.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/sound/soc/codecs/nau8325.c b/sound/soc/codecs/nau8325.c
index 5b3115b0a7e58193b5e9485ae2effaffcad28dbb..d396160213f5db199dc363f7af076b1531102412 100644 (file)
--- a/sound/soc/codecs/nau8325.c
+++ b/sound/soc/codecs/nau8325.c
@@ -386,7 +386,8 @@ static int nau8325_clksrc_choose(struct nau8325 *nau8325,
                                 const struct nau8325_srate_attr **srate_table,
                                 int *n1_sel, int *mult_sel, int *n2_sel)
 {
-       int i, j, mclk, mclk_max, ratio, ratio_sel, n2_max;
+       int i, j, mclk, ratio;
+       int mclk_max = 0, ratio_sel = 0, n2_max = 0;
 
        if (!nau8325->mclk || !nau8325->fs)
                goto proc_err;
@@ -408,7 +409,6 @@ static int nau8325_clksrc_choose(struct nau8325 *nau8325,
        }
 
        /* Get MCLK_SRC through 1/N, Multiplier, and then 1/N2. */
-       mclk_max = 0;
        for (i = 0; i < ARRAY_SIZE(mclk_n1_div); i++) {
                for (j = 0; j < ARRAY_SIZE(mclk_n3_mult); j++) {
                        mclk = nau8325->mclk << mclk_n3_mult[j].param;