]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ALSA: firewire: isight: Use safer strscpy() instead of strcpy()
authorTakashi Iwai <tiwai@suse.de>
Thu, 10 Jul 2025 10:06:00 +0000 (12:06 +0200)
committerTakashi Iwai <tiwai@suse.de>
Fri, 11 Jul 2025 07:52:51 +0000 (09:52 +0200)
Use a safer function strscpy() instead of strcpy() for copying to
arrays.

Only idiomatic code replacement, and no functional changes.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://patch.msgid.link/20250710100727.22653-19-tiwai@suse.de
sound/firewire/isight.c

index b1e059f0d4736240221a049329b309a655ba3019..ee574b5d7406bb76d2f932634d01d55e5a78d065 100644 (file)
@@ -455,7 +455,7 @@ static int isight_create_pcm(struct isight *isight)
                return err;
        pcm->private_data = isight;
        pcm->nonatomic = true;
-       strcpy(pcm->name, "iSight");
+       strscpy(pcm->name, "iSight");
        isight->pcm = pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream;
        isight->pcm->ops = &ops;
        snd_pcm_set_managed_buffer_all(pcm, SNDRV_DMA_TYPE_VMALLOC, NULL, 0, 0);
@@ -638,13 +638,13 @@ static int isight_probe(struct fw_unit *unit,
 
        card->private_free = isight_card_free;
 
-       strcpy(card->driver, "iSight");
-       strcpy(card->shortname, "Apple iSight");
+       strscpy(card->driver, "iSight");
+       strscpy(card->shortname, "Apple iSight");
        snprintf(card->longname, sizeof(card->longname),
                 "Apple iSight (GUID %08x%08x) at %s, S%d",
                 fw_dev->config_rom[3], fw_dev->config_rom[4],
                 dev_name(&unit->device), 100 << fw_dev->max_speed);
-       strcpy(card->mixername, "iSight");
+       strscpy(card->mixername, "iSight");
 
        err = isight_create_pcm(isight);
        if (err < 0)