]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
iio: accel: bma400: Add detail to comments in GEN INTR configuration
authorAkshay Jindal <akshayaj.lkd@gmail.com>
Sun, 12 Oct 2025 18:06:13 +0000 (23:36 +0530)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 19 Oct 2025 10:59:23 +0000 (11:59 +0100)
Append additional information to existing comments in the generic
interrupt configuration code to provide more context.

Signed-off-by: Akshay Jindal <akshayaj.lkd@gmail.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/accel/bma400_core.c

index 840c4156ba6042063777c04578b1c568a31cf51b..05f72707f8306880b8b8d6aeef928715f83a6a3a 100644 (file)
@@ -1208,7 +1208,10 @@ static int bma400_generic_event_en(struct bma400_data *data,
        detect_criterion = bma400_genintr->detect_mode;
        intrmask = bma400_genintr->intrmask;
 
-       /* Enabling all axis for interrupt evaluation */
+       /*
+        * Enabling all axis for interrupt evaluation
+        * Acc_filt2 is recommended as data source in datasheet (Section 4.7)
+        */
        ret = regmap_write(data->regmap, BMA400_GENINT_CONFIG_REG(genintr, 0),
                           BMA400_GENINT_CONFIG0_X_EN_MASK |
                           BMA400_GENINT_CONFIG0_Y_EN_MASK |
@@ -1226,7 +1229,10 @@ static int bma400_generic_event_en(struct bma400_data *data,
        if (ret)
                return ret;
 
-       /* Initial value to avoid interrupts while enabling*/
+       /*
+        * Initial value to avoid interrupts while enabling
+        * Value is in units of 8mg/lsb, i.e. effective val is val * 8mg/lsb
+        */
        ret = regmap_write(data->regmap, BMA400_GENINT_CONFIG_REG(genintr, 2), 0x0A);
        if (ret)
                return ret;