]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
conf: Avoid double free in virDomainEventTunableNew callers
authorJiri Denemark <jdenemar@redhat.com>
Wed, 2 Nov 2022 14:10:25 +0000 (15:10 +0100)
committerJiri Denemark <jdenemar@redhat.com>
Wed, 2 Nov 2022 15:10:38 +0000 (16:10 +0100)
virDomainEventTunableNew is supposed to consume and free @params, but it
failed to always set @params to NULL to make sure the caller doesn't try
to free the same memory again.

Fixes: d95c79fbd00dc597b607b130d95c258b6cf31690
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
src/conf/domain_event.c

index 97d58c25213871a18cc4d005b39960a62cc3b8f5..7e9bd083814ebda203823d2633dc957ea8af0208 100644 (file)
@@ -1515,6 +1515,7 @@ virDomainEventTunableNew(int id,
 
  error:
     virTypedParamsFree(*params, nparams);
+    *params = NULL;
     return NULL;
 }