]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
rtc: mt6397: check return value after calling platform_get_resource()
authorYang Yingliang <yangyingliang@huawei.com>
Thu, 5 May 2022 12:50:43 +0000 (20:50 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Jun 2022 14:59:32 +0000 (16:59 +0200)
[ Upstream commit d3b43eb505bffb8e4cdf6800c15660c001553fe6 ]

It will cause null-ptr-deref if platform_get_resource() returns NULL,
we need check the return value.

Fixes: fc2979118f3f ("rtc: mediatek: Add MT6397 RTC driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20220505125043.1594771-1-yangyingliang@huawei.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/rtc/rtc-mt6397.c

index 964ed91416e1b174da0d0bb00bf2d67d3f95d092..671b6d275da3e8c12fb7d30207485de30f80c3e6 100644 (file)
@@ -339,6 +339,8 @@ static int mtk_rtc_probe(struct platform_device *pdev)
                return -ENOMEM;
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+       if (!res)
+               return -EINVAL;
        rtc->addr_base = res->start;
 
        rtc->irq = platform_get_irq(pdev, 0);