]> git.ipfire.org Git - thirdparty/u-boot.git/commitdiff
power: domain: Validate device tree node in dev_power_domain_ctrl
authorPeng Fan <peng.fan@nxp.com>
Tue, 10 Feb 2026 08:12:15 +0000 (16:12 +0800)
committerTom Rini <trini@konsulko.com>
Thu, 26 Feb 2026 15:04:46 +0000 (09:04 -0600)
Similar to pinctrl_select_state(), add dev_has_ofnode() check before doing the
real work. Device(scmi_base.0) does not have a real device node, ofnode_null()
is assigned as the device tree node for scmi base protocol device:
'commit 7eb4eb541c14 ("firmware: scmi: install base protocol to SCMI agent")'

However with recent update in
'commit 0535e46d55d7 ("scripts/dtc: Update to upstream version v1.7.2-35-g52f07dcca47c")',
SPL panic in fdt_check_node_offset_()->fdt_next_tag(), because offset is -1
and SPL_OF_LIBFDT_ASSUME_MASK is 0xFF.

So need to validate device tree node.

Reported-by: Ye Li <ye.li@nxp.com>
Closes: https://lore.kernel.org/u-boot/939a9696-27fa-45a1-b428-feffe21ac6d5@oss.nxp.com/
Signed-off-by: Peng Fan <peng.fan@nxp.com>
drivers/power/domain/power-domain-uclass.c

index d9fa8ad4bd2126ea564fd5be8124035946dbd432..cea68945cbdba528a304c7a3fa08ed2b004c4ab8 100644 (file)
@@ -180,6 +180,9 @@ static int dev_power_domain_ctrl(struct udevice *dev, bool on)
        struct power_domain pd;
        int i, count, ret = 0;
 
+       if (!dev_has_ofnode(dev))
+               return 0;
+
        count = dev_count_phandle_with_args(dev, "power-domains",
                                            "#power-domain-cells", 0);
        for (i = 0; i < count; i++) {