srtpkdf: cipher is written twice with the same value

Resolves: https://scan5.scan.coverity.com/#/project-view/65138/10222?selectedIssue=1681392
Fixes: 5b310281af9a ("SRTP: Fixup settable input limits and test them.")
Signed-off-by: Nikola Pajkovsky <nikolap@openssl.org>
Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Paul Dale <paul.dale@oracle.com>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
MergeDate: Wed Feb 18 16:34:01 2026
(Merged from https://github.com/openssl/openssl/pull/30040)

diff --git a/providers/implementations/kdfs/srtpkdf.c b/providers/implementations/kdfs/srtpkdf.c
index cf388d1d7a527405a057e7b945cdfa871f4bd9ef..f8839ff59a0a03683fb9a112dd2a4b24753ba408 100644 (file)
--- a/providers/implementations/kdfs/srtpkdf.c
+++ b/providers/implementations/kdfs/srtpkdf.c
@@ -172,7 +172,7 @@ static int is_power_of_two(uint32_t x, uint32_t *n)
 
 static int kdf_srtpkdf_check_key(KDF_SRTPKDF *ctx)
 {
-    const EVP_CIPHER *cipher = cipher = ossl_prov_cipher_cipher(&ctx->cipher);
+    const EVP_CIPHER *cipher = ossl_prov_cipher_cipher(&ctx->cipher);
 
     if (cipher != NULL) {
         if (ctx->key == NULL) {