]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: ethernet: aquantia: Fix wrong return value
authorTianjia Zhang <tianjia.zhang@linux.alibaba.com>
Sun, 2 Aug 2020 11:15:37 +0000 (19:15 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 Aug 2020 06:24:06 +0000 (08:24 +0200)
[ Upstream commit 0470a48880f8bc42ce26962b79c7b802c5a695ec ]

In function hw_atl_a0_hw_multicast_list_set(), when an invalid
request is encountered, a negative error code should be returned.

Fixes: bab6de8fd180b ("net: ethernet: aquantia: Atlantic A0 and B0 specific functions")
Cc: David VomLehn <vomlehn@texas.net>
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/aquantia/atlantic/hw_atl/hw_atl_a0.c

index 9b1062b8af640534a4b23e026e8366e89533321a..1e8b778cb9fa25b9e91e57163f028c77a5a9a199 100644 (file)
@@ -782,7 +782,7 @@ static int hw_atl_a0_hw_multicast_list_set(struct aq_hw_s *self,
        int err = 0;
 
        if (count > (HW_ATL_A0_MAC_MAX - HW_ATL_A0_MAC_MIN)) {
-               err = EBADRQC;
+               err = -EBADRQC;
                goto err_exit;
        }
        for (self->aq_nic_cfg->mc_list_count = 0U;