]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
Don't leak memory on invalid packet code (#4887)
authorJorge Pereira <jpereira@users.noreply.github.com>
Wed, 8 Feb 2023 15:50:53 +0000 (12:50 -0300)
committerGitHub <noreply@github.com>
Wed, 8 Feb 2023 15:50:53 +0000 (10:50 -0500)
src/protocols/tacacs/decode.c

index dcf18839bfc12403cb3c31321b35f6ac053f6101..7265b3c5e4df9f83f2daa436bb4b843147af90c2 100644 (file)
@@ -472,7 +472,7 @@ ssize_t fr_tacacs_decode(TALLOC_CTX *ctx, fr_pair_list_t *out, uint8_t const *bu
 
                if (code) {
                        *code = fr_tacacs_packet_to_code((fr_tacacs_packet_t const *) decrypted);
-                       if (*code < 0) return -1;
+                       if (*code < 0) goto fail;
                }
        }