replay: die if we cannot parse object

`parse_object` can return `NULL`. That will in turn make
`repo_peel_to_type` return the same.

Let’s die fast and descriptively with the `*_or_die` variant.

Suggested-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/builtin/replay.c b/builtin/replay.c
index 402db44af2b38fa91a717bf85534ca95e1f696fe..1960bbbee8685d2828d06281f02f06e1c2b97993 100644 (file)
--- a/builtin/replay.c
+++ b/builtin/replay.c
@@ -42,7 +42,7 @@ static struct commit *peel_committish(struct repository *repo,
 
        if (repo_get_oid(repo, name, &oid))
                die(_("'%s' is not a valid commit-ish for %s"), name, mode);
-       obj = parse_object(repo, &oid);
+       obj = parse_object_or_die(repo, &oid, name);
        return (struct commit *)repo_peel_to_type(repo, name, 0, obj,
                                                  OBJ_COMMIT);
 }