]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
lib: Remove unnecessary assignments
authorVolker Lendecke <vl@samba.org>
Wed, 24 Dec 2025 09:58:52 +0000 (10:58 +0100)
committerVolker Lendecke <vl@samba.org>
Wed, 7 Jan 2026 09:57:40 +0000 (09:57 +0000)
data_blob_free() already NULLs out its argument

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Anoop C S <anoopcs@samba.org>
lib/util/asn1.c
source3/utils/ntlm_auth.c

index 644f40275ee3d1bdfcb07ab82c0c5a0c30e4ddec..4e2999ec60ac132118a38a80569c09002642b190 100644 (file)
@@ -960,7 +960,6 @@ bool asn1_read_OctetString(struct asn1_data *data, TALLOC_CTX *mem_ctx, DATA_BLO
   err:
 
        data_blob_free(blob);
-       *blob = data_blob_null;
        return false;
 }
 
@@ -1047,7 +1046,6 @@ bool asn1_read_BitString(struct asn1_data *data, TALLOC_CTX *mem_ctx, DATA_BLOB
 
        if (data->has_error) {
                data_blob_free(blob);
-               *blob = data_blob_null;
                *padding = 0;
                return false;
        }
index ced45fe61c92aa319fb30bfa4a0144f5ca2a8407..d32a985098047f753141ac818218b98de938c13d 100644 (file)
@@ -2007,11 +2007,8 @@ static void manage_ntlm_server_1_request(enum stdio_helper_mode stdio_helper_mod
                }
                /* clear out the state */
                data_blob_free(&challenge);
-               challenge = data_blob_null;
                data_blob_free(&nt_response);
-               nt_response = data_blob_null;
                data_blob_free(&lm_response);
-               lm_response = data_blob_null;
                SAFE_FREE(full_username);
                SAFE_FREE(username);
                SAFE_FREE(domain);