]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
Enable JSON testing for pymysql
authorMike Bayer <mike_mp@zzzcomputing.com>
Fri, 29 Jul 2016 15:05:28 +0000 (11:05 -0400)
committerMike Bayer <mike_mp@zzzcomputing.com>
Fri, 29 Jul 2016 15:07:32 +0000 (11:07 -0400)
PyMySQL upstream has released 0.7.6 which should resolve
JSON encoding issues.

Change-Id: Icf543d48dace1419a0aac78bdb15ec666f0edafe
Fixes: #3754
test/requirements.py

index 5f366ba478826883c05648e89e177324f4b96890..9286a415d193c0acd35f3f8db4e9dfd7d30d029d 100644 (file)
@@ -574,10 +574,7 @@ class DefaultRequirements(SuiteRequirements):
     def json_type(self):
         return only_on([
             lambda config: against(config, "mysql >= 5.7") and
-            not config.db.dialect._is_mariadb and
-            # workaround for:
-            # https://github.com/PyMySQL/PyMySQL/issues/488
-            not (config.db.dialect.driver == 'pymysql'),
+            not config.db.dialect._is_mariadb,
             "postgresql >= 9.3"
         ])