]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: synopsys: csi2rx: only check errors from devm_clk_bulk_get_all()
authorFrank Li <Frank.Li@nxp.com>
Mon, 16 Feb 2026 19:18:40 +0000 (14:18 -0500)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Thu, 26 Mar 2026 13:33:07 +0000 (14:33 +0100)
devm_clk_bulk_get_all() returns all clocks described in the DT, which are
already validated by the binding. Do not need enforce an expected clock
count.

Only check for error returns (< 0) to support more SoCs.

Reviewed-by: Michael Riesch <michael.riesch@collabora.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/platform/synopsys/dw-mipi-csi2rx.c

index 0cc892f4a1b3c6ce575a5d4fca7acf7057f7b7f7..f03fe01280013bf9a832433c6b06dab691bf8f4c 100644 (file)
@@ -40,8 +40,6 @@
 #define SW_DATATYPE_LS(x)      ((x) << 20)
 #define SW_DATATYPE_LE(x)      ((x) << 26)
 
-#define DW_MIPI_CSI2RX_CLKS_MAX        1
-
 enum {
        DW_MIPI_CSI2RX_PAD_SINK,
        DW_MIPI_CSI2RX_PAD_SRC,
@@ -630,7 +628,7 @@ static int dw_mipi_csi2rx_probe(struct platform_device *pdev)
                return PTR_ERR(csi2->base_addr);
 
        ret = devm_clk_bulk_get_all(dev, &csi2->clks);
-       if (ret != DW_MIPI_CSI2RX_CLKS_MAX)
+       if (ret < 0)
                return dev_err_probe(dev, -ENODEV, "failed to get clocks\n");
        csi2->clks_num = ret;