Clarify parse error for ascend attributes

Printing to the same string we're reading from is a bad idea.

diff --git a/src/lib/valuepair.c b/src/lib/valuepair.c
index 6e63e7abfccf7983d15083ceacaf3ea516b2427d..bda19385eeac5eacc899e13c7a9729d4b2453af3 100644 (file)
--- a/src/lib/valuepair.c
+++ b/src/lib/valuepair.c
@@ -1069,8 +1069,10 @@ VALUE_PAIR *pairparsevalue(VALUE_PAIR *vp, const char *value)
                        }
 
                        if (ascend_parse_filter(vp) < 0 ) {
-                               fr_strerror_printf("failed to parse Ascend binary attribute: %s",
-                                          fr_strerror());
+                               char buffer[256];
+
+                               snprintf(buffer, sizeof(buffer), "failed to parse Ascend binary attribute: %s", fr_strerror());
+                               fr_strerror_printf("%s", buffer);
                                return NULL;
                        }
                        break;