check returns. CID #1503939 Fixes #5103

diff --git a/src/lib/util/edit_tests.c b/src/lib/util/edit_tests.c
index 836071d30535a1f4000b935b859e41a68bd35c9e..55e1411edfbeb6289c714da21dee865cc5f2d078 100644 (file)
--- a/src/lib/util/edit_tests.c
+++ b/src/lib/util/edit_tests.c
@@ -82,15 +82,18 @@ static void test_init(void)
 static void add_pairs(fr_pair_list_t *local_pairs)
 {
        int count;
+       fr_pair_t *vp;
 
        fr_pair_list_init(local_pairs);
 
-       /* coverity[dereference] */
-       fr_pair_append(local_pairs, fr_pair_afrom_da(autofree, fr_dict_attr_test_uint32));
-       /* coverity[dereference] */
-       fr_pair_append(local_pairs, fr_pair_afrom_da(autofree, fr_dict_attr_test_octets));
-       /* coverity[dereference] */
-       fr_pair_append(local_pairs, fr_pair_afrom_da(autofree, fr_dict_attr_test_tlv));
+       TEST_ASSERT((vp = fr_pair_afrom_da(autofree, fr_dict_attr_test_uint32)) != NULL);
+       fr_pair_append(local_pairs, vp);
+
+       TEST_ASSERT((vp = fr_pair_afrom_da(autofree, fr_dict_attr_test_octets)) != NULL);
+       fr_pair_append(local_pairs, vp);
+
+       TEST_ASSERT((vp = fr_pair_afrom_da(autofree, fr_dict_attr_test_tlv)) != NULL);
+       fr_pair_append(local_pairs, vp);
 
        count = fr_pair_list_num_elements(local_pairs);
        TEST_CASE("Expected (count == 3)");