]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
flow-manager: avoid doubly signaling threads
authorVictor Julien <victor@inliniac.net>
Sun, 3 Nov 2019 19:42:47 +0000 (20:42 +0100)
committerVictor Julien <victor@inliniac.net>
Fri, 7 Feb 2020 14:43:10 +0000 (15:43 +0100)
Don't try to wake up the threads we just flagged and validated that
they changed their state.

src/flow-manager.c

index e515332192c4ab64373e87c981fbbf5ec5858e72..ddfdbdd887da3332628b0366333e78911f3748c6 100644 (file)
@@ -190,10 +190,6 @@ again:
     }
     SCMutexUnlock(&tv_root_lock);
 
-    /* wake up threads, another try */
-    for (u = 0; u < flowmgr_number; u++)
-        SCCtrlCondSignal(&flow_manager_ctrl_cond);
-
     /* reset count, so we can kill and respawn (unix socket) */
     SC_ATOMIC_SET(flowmgr_cnt, 0);
     return;
@@ -1155,10 +1151,6 @@ again:
     }
     SCMutexUnlock(&tv_root_lock);
 
-    /* wake up threads, another try */
-    for (u = 0; u < flowrec_number; u++)
-        SCCtrlCondSignal(&flow_recycler_ctrl_cond);
-
     /* reset count, so we can kill and respawn (unix socket) */
     SC_ATOMIC_SET(flowrec_cnt, 0);
     return;