s4:auth: let auth_domain_admin_user_info_dc() use talloc_zero_array(struct auth_SidAttr)

This means we won't leave uninitialized memory if
struct auth_SidAttr changes.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jennifer Sutton <jennifersutton@catalyst.net.nz>

diff --git a/source4/auth/system_session.c b/source4/auth/system_session.c
index 8b4b65f3cd46e526c4ac6c8db53a3939eb3c6c8d..3a58f130462be9b3df22453fef6a8b7b2aeca66f 100644 (file)
--- a/source4/auth/system_session.c
+++ b/source4/auth/system_session.c
@@ -247,7 +247,13 @@ static NTSTATUS auth_domain_admin_user_info_dc(TALLOC_CTX *mem_ctx,
        NT_STATUS_HAVE_NO_MEMORY(user_info_dc);
 
        user_info_dc->num_sids = 8;
-       user_info_dc->sids = talloc_array(user_info_dc, struct auth_SidAttr, user_info_dc->num_sids);
+       user_info_dc->sids = talloc_zero_array(user_info_dc,
+                                              struct auth_SidAttr,
+                                              user_info_dc->num_sids);
+       if (user_info_dc->sids == NULL) {
+               TALLOC_FREE(user_info_dc);
+               return NT_STATUS_NO_MEMORY;
+       }
 
        user_info_dc->sids[PRIMARY_USER_SID_INDEX].sid = *domain_sid;
        sid_append_rid(&user_info_dc->sids[PRIMARY_USER_SID_INDEX].sid, DOMAIN_RID_ADMINISTRATOR);