]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
tools/mm/page_owner_sort: fix timestamp comparison for stable sorting
authorKaushlendra Kumar <kaushlendra.kumar@intel.com>
Tue, 9 Dec 2025 04:45:52 +0000 (10:15 +0530)
committerAndrew Morton <akpm@linux-foundation.org>
Tue, 23 Dec 2025 19:23:14 +0000 (11:23 -0800)
The ternary operator in compare_ts() returns 1 when timestamps are equal,
causing unstable sorting behavior. Replace with explicit three-way
comparison that returns 0 for equal timestamps, ensuring stable qsort
ordering and consistent output.

Link: https://lkml.kernel.org/r/20251209044552.3396468-1-kaushlendra.kumar@intel.com
Fixes: 8f9c447e2e2b ("tools/vm/page_owner_sort.c: support sorting pid and time")
Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
Cc: Chongxi Zhao <zhaochongxi2019@email.szu.edu.cn>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
tools/mm/page_owner_sort.c

index 14c67e9e84c42bc7b3ee4ec868440f6e6bbf01f4..e6954909401c8e79d0893ade8cecf0c143ec29ec 100644 (file)
@@ -181,7 +181,11 @@ static int compare_ts(const void *p1, const void *p2)
 {
        const struct block_list *l1 = p1, *l2 = p2;
 
-       return l1->ts_nsec < l2->ts_nsec ? -1 : 1;
+       if (l1->ts_nsec < l2->ts_nsec)
+               return -1;
+       if (l1->ts_nsec > l2->ts_nsec)
+               return 1;
+       return 0;
 }
 
 static int compare_cull_condition(const void *p1, const void *p2)