]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
phy: qcom: m31-eusb2: Update init sequence to set PHY_ENABLE
authorRonak Raheja <ronak.raheja@oss.qualcomm.com>
Sat, 20 Sep 2025 03:21:58 +0000 (20:21 -0700)
committerVinod Koul <vkoul@kernel.org>
Thu, 20 Nov 2025 16:47:44 +0000 (22:17 +0530)
Certain platforms may not have the PHY_ENABLE bit set on power on reset.
Update the current sequence to explicitly write to enable the PHY_ENABLE
bit.  This ensures that regardless of the platform, the PHY is properly
enabled.

Signed-off-by: Ronak Raheja <ronak.raheja@oss.qualcomm.com>
Signed-off-by: Wesley Cheng <wesley.cheng@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patch.msgid.link/20250920032158.242725-1-wesley.cheng@oss.qualcomm.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/qualcomm/phy-qcom-m31-eusb2.c

index 0a0d2d9fc846480878c19f34435ccd6df242a1bf..95cd3175926d56f9467d4ebf911d47b0403f0ce9 100644 (file)
@@ -25,6 +25,7 @@
 #define POR                            BIT(1)
 
 #define USB_PHY_HS_PHY_CTRL_COMMON0    (0x54)
+#define PHY_ENABLE                     BIT(0)
 #define SIDDQ_SEL                      BIT(1)
 #define SIDDQ                          BIT(2)
 #define FSEL                           GENMASK(6, 4)
@@ -81,6 +82,7 @@ struct m31_eusb2_priv_data {
 static const struct m31_phy_tbl_entry m31_eusb2_setup_tbl[] = {
        M31_EUSB_PHY_INIT_CFG(USB_PHY_CFG0, UTMI_PHY_CMN_CTRL_OVERRIDE_EN, 1),
        M31_EUSB_PHY_INIT_CFG(USB_PHY_UTMI_CTRL5, POR, 1),
+       M31_EUSB_PHY_INIT_CFG(USB_PHY_HS_PHY_CTRL_COMMON0, PHY_ENABLE, 1),
        M31_EUSB_PHY_INIT_CFG(USB_PHY_CFG1, PLL_EN, 1),
        M31_EUSB_PHY_INIT_CFG(USB_PHY_FSEL_SEL, FSEL_SEL, 1),
 };