]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ocfs2: Drop pointless sync_mapping_buffers() calls
authorJan Kara <jack@suse.cz>
Thu, 26 Mar 2026 09:53:58 +0000 (10:53 +0100)
committerChristian Brauner <brauner@kernel.org>
Thu, 26 Mar 2026 14:03:27 +0000 (15:03 +0100)
ocfs2 never calls mark_buffer_dirty_inode() and thus its metadata
buffers list is always empty. Drop the pointless sync_mapping_buffers()
calls.

CC: Joel Becker <jlbec@evilplan.org>
CC: Joseph Qi <joseph.qi@linux.alibaba.com>
CC: ocfs2-devel@lists.linux.dev
Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://patch.msgid.link/20260326095354.16340-46-jack@suse.cz
Tested-by: syzbot@syzkaller.appspotmail.com
Reviewed-by: Joseph Qi <joseph.qi@linux.alibaba.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/ocfs2/dlmglue.c
fs/ocfs2/namei.c

index bd2ddb7d841dfa368fa61a8dd024455e339e9aa4..7283bb2c5a31bf9c2595036dfa167153a08a2203 100644 (file)
@@ -3971,7 +3971,6 @@ static int ocfs2_data_convert_worker(struct ocfs2_lock_res *lockres,
                mlog(ML_ERROR, "Could not sync inode %llu for downconvert!",
                     (unsigned long long)OCFS2_I(inode)->ip_blkno);
        }
-       sync_mapping_buffers(mapping);
        if (blocking == DLM_LOCK_EX) {
                truncate_inode_pages(mapping, 0);
        } else {
index 268b79339a517840c96b7cc900ec88e13ea5aeb6..1277666c77cd2d4446ba5cb92018a5b0d78d22b8 100644 (file)
@@ -1683,9 +1683,6 @@ bail:
        if (rename_lock)
                ocfs2_rename_unlock(osb);
 
-       if (new_inode)
-               sync_mapping_buffers(old_inode->i_mapping);
-
        iput(new_inode);
 
        ocfs2_free_dir_lookup_result(&target_lookup_res);