]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
phy: qcom: edp: Fix NULL pointer dereference for phy v6 (x1e80100)
authorVal Packett <val@packett.cool>
Sun, 11 Jan 2026 08:25:59 +0000 (05:25 -0300)
committerVinod Koul <vkoul@kernel.org>
Wed, 14 Jan 2026 13:37:30 +0000 (19:07 +0530)
For Glymur SoC support, the com_clk_fwd_cfg callback was added, and a
stub implementation was added for the v4 of the hardware. However it
was omitted for the v6, causing a NULL pointer dereference oops on
Hamoa/Purwa (X1E/X1P) SoC devices. Fix by adding the appropriate stub.

Fixes: add66a6673bc ("phy: qcom: edp: Add Glymur platform support")
Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
Signed-off-by: Val Packett <val@packett.cool>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Tested-by: Yijie Yang <yijie.yang@oss.qualcomm.com> # Purwa-IoT-EVK
Link: https://patch.msgid.link/20260111083317.604754-1-val@packett.cool
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/qualcomm/phy-qcom-edp.c

index 13feab99feec1c4b7e0d340fe9ed6c4b32728cbc..7372de05a0b8113efc09802073aa8f4d722dec08 100644 (file)
@@ -758,6 +758,7 @@ static const struct phy_ver_ops qcom_edp_phy_ops_v6 = {
        .com_power_on           = qcom_edp_phy_power_on_v6,
        .com_resetsm_cntrl      = qcom_edp_phy_com_resetsm_cntrl_v6,
        .com_bias_en_clkbuflr   = qcom_edp_com_bias_en_clkbuflr_v6,
+       .com_clk_fwd_cfg        = qcom_edp_com_clk_fwd_cfg_v4,
        .com_configure_pll      = qcom_edp_com_configure_pll_v6,
        .com_configure_ssc      = qcom_edp_com_configure_ssc_v6,
 };