]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
Fix flags passed to virDomainDefParseString by XenAPI driver
authorDaniel P. Berrange <berrange@redhat.com>
Tue, 18 Nov 2014 16:02:11 +0000 (16:02 +0000)
committerDaniel P. Berrange <berrange@redhat.com>
Tue, 13 Jan 2015 10:43:07 +0000 (10:43 +0000)
The XenAPI driver was passing the flags for
virDomainCreateXML straight into the virDomainDefParseString
method, even though they expect totally different sets of
flags. It should have been using VIR_DOMAIN_XML_INACTIVE

src/xenapi/xenapi_driver.c

index 1ab433a6ae618853da2bf638ebb3c20cf88d7eb3..2625794666132f0f6e4c5c2fef284b77b2b91e51 100644 (file)
@@ -554,7 +554,7 @@ xenapiDomainCreateXML(virConnectPtr conn,
     virDomainDefPtr defPtr = virDomainDefParseString(xmlDesc,
                                                      priv->caps, priv->xmlopt,
                                                      1 << VIR_DOMAIN_VIRT_XEN,
-                                                     flags);
+                                                     VIR_DOMAIN_XML_INACTIVE);
     createVMRecordFromXml(conn, defPtr, &record, &vm);
     virDomainDefFree(defPtr);
     if (record) {
@@ -1728,7 +1728,7 @@ xenapiDomainDefineXMLFlags(virConnectPtr conn, const char *xml, unsigned int fla
     virDomainDefPtr defPtr = virDomainDefParseString(xml,
                                                      priv->caps, priv->xmlopt,
                                                      1 << VIR_DOMAIN_VIRT_XEN,
-                                                     0);
+                                                     VIR_DOMAIN_XML_INACTIVE);
     if (!defPtr)
         return NULL;