wifi: mt76x2u: drop redundant device reference

Driver core holds a reference to the USB interface and its parent USB
device while the interface is bound to a driver and there is no need to
take additional references unless the structures are needed after
disconnect.

Drop the redundant device reference to reduce cargo culting, make it
easier to spot drivers where an extra reference is needed, and reduce
the risk of memory leaks when drivers fail to release it.

Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20260430083335.215239-4-johan@kernel.org
Signed-off-by: Felix Fietkau <nbd@nbd.name>

diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2/usb.c b/drivers/net/wireless/mediatek/mt76/mt76x2/usb.c
index 01cb3b2830f35b85fab4788481ec8878d37c0c7a..8af360bca6439604ec204f9942166081aa10a4fe 100644 (file)
--- a/drivers/net/wireless/mediatek/mt76/mt76x2/usb.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76x2/usb.c
@@ -57,7 +57,6 @@ static int mt76x2u_probe(struct usb_interface *intf,
 
        dev = container_of(mdev, struct mt76x02_dev, mt76);
 
-       udev = usb_get_dev(udev);
        usb_reset_device(udev);
 
        usb_set_intfdata(intf, dev);
@@ -84,14 +83,12 @@ err:
        mt76u_queues_deinit(&dev->mt76);
        mt76_free_device(&dev->mt76);
        usb_set_intfdata(intf, NULL);
-       usb_put_dev(udev);
 
        return err;
 }
 
 static void mt76x2u_disconnect(struct usb_interface *intf)
 {
-       struct usb_device *udev = interface_to_usbdev(intf);
        struct mt76x02_dev *dev = usb_get_intfdata(intf);
        struct ieee80211_hw *hw = mt76_hw(dev);
 
@@ -100,7 +97,6 @@ static void mt76x2u_disconnect(struct usb_interface *intf)
        mt76x2u_cleanup(dev);
        mt76_free_device(&dev->mt76);
        usb_set_intfdata(intf, NULL);
-       usb_put_dev(udev);
 }
 
 static int __maybe_unused mt76x2u_suspend(struct usb_interface *intf,