]> git.ipfire.org Git - thirdparty/tornado.git/commitdiff
Revert "websockets: continue listening for messages after parsing completion"
authorBen Darnell <bdarnell@beaker.local>
Sat, 29 May 2010 00:12:34 +0000 (17:12 -0700)
committerBen Darnell <bdarnell@beaker.local>
Sat, 29 May 2010 00:16:52 +0000 (17:16 -0700)
This reverts commit 9ea5f8a277db96557ae7867375c7db4d8c5f633a.

The one-shot behavior of receive_message was intentional, and simply
requeuing the old callback every time will eventually overflow the
stack due to repeated async_callback wrappers.  An alternate interface
that doesn't require receive_message to be called for every message
may be added in a future change.

See discussion at
http://github.com/facebook/tornado/commit/9ea5f8a277db96557ae7867375c7db4d8c5f633a

tornado/websocket.py

index 11f8b0653e2ce84960383936ccfc9a3f6f766229..dfca709c44f855d356b356e6fb9bed1d5133969e 100644 (file)
@@ -127,7 +127,6 @@ class WebSocketHandler(tornado.web.RequestHandler):
 
     def _on_end_delimiter(self, callback, frame):
         callback(frame[:-1].decode("utf-8", "replace"))
-        self.receive_message(callback)
 
     def _not_supported(self, *args, **kwargs):
         raise Exception("Method not supported for Web Sockets")